Code Refactoring

Activity 1.36.1.

There is a copy of the following code block in an interactive mode that you can modify and compile. Your task is to improve the code’s style as an expert would view it, while ensuring its behavior remains unchanged. You may run your refactored code to verify that it still passes all test cases. Imagine str is not null.

public class SWord {
	public static boolean startsWithS(String str) {
		if (str.isEmpty() || str.charAt(0) != 'S') {
			return false;
		} else {
			return true;
		}
	}
}

public class SWord {
	public static boolean startsWithS(String str) {
		if (str.isEmpty() || str.charAt(0)!='S') {
			return false;
		} else {
			return true;
		}
	}
}
====
      import static org.junit.Assert.*;
import org.junit.Test;
import java.io.*;
import org.junit.Before;
import org.junit.After;
import java.io.ByteArrayOutputStream;
import java.io.PrintStream;

public class RunestoneTests extends CodeTestHelper {

public RunestoneTests() {
		super("SWord");
	}

// Test for "sarah" lower s
	@Test
	public void testWithin() throws IOException {
		Object[] args = {"sarah"};  // Arguments for the method
		String output = getMethodOutput("startsWithS", args);
		String expect = Boolean.toString(false);  // Convert expected boolean to String
		
		boolean passed = getResults(expect, output, "startsWithS(\"sarah\")");  // Fixed the quotation
		assertTrue(passed);
	}

// Test for empty string
	@Test
	public void testEmptyString() throws IOException {
		Object[] args = {""};  // Arguments for the method
		String output = getMethodOutput("startsWithS", args);
		String expect = Boolean.toString(false);  // Convert expected boolean to String
		
		boolean passed = getResults(expect, output, "startsWithS(\"\")");  // Fixed the quotation
		assertTrue(passed);
	}

// Test for word with capital S
	@Test
	public void testWithUpperCaseS() throws IOException {
		Object[] args = {"SOS"};  // Arguments for the method
		String output = getMethodOutput("startsWithS", args);
		String expect = Boolean.toString(true);  // Convert expected boolean to String
		
		boolean passed = getResults(expect, output, "startsWithS(\"SOS\")");  // Fixed the quotation
		assertTrue(passed);
	}

// Test for "abs"
	@Test
	public void testWithAbs() throws IOException {
		Object[] args = {"abs"};  // Arguments for the method
		String output = getMethodOutput("startsWithS", args);
		String expect = Boolean.toString(false);  // Convert expected boolean to String
		
		boolean passed = getResults(expect, output, "startsWithS(\"abs\")");  // Fixed the quotation
		assertTrue(passed);
	}

}

Activity 1.36.2.

Which of the following code blocks is the most similar to your final refactored code for the previous question?

public class SWord {
	public static boolean startsWithS(String str) {
		if (!str.isEmpty() && str.charAt(0) == 'S') {
			return true;
		} 
		return false;
	}
}

This code can further be improved!

public class SWord {
	public static boolean startsWithS(String str) {
		if (str.isEmpty()) {
			return false;
		} 
		return str.charAt(0) == 'S';
	}
}

You refactored correctly!

public class SWord {
	public static boolean startsWithS(String str) {
		return !str.isEmpty() && str.charAt(0) == 'S';
	}
}

You refactored correctly!

Section 1.36 Code Refactoring

Activity 1.36.1.

Activity 1.36.2.